fix: use consistent version of ktlint in build-support plugin and ensure that kotlin-compiler-embeddable isn't in buildscript classpaths #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure that kotlin-compiler-embeddable isn't in buildscript classpaths
lauzadis
approved these changes
Feb 20, 2025
Member
lauzadis
left a comment
lauzadis
left a comment
There was a problem hiding this comment.
Approving pending investigation around the style changes caused by max_line_length. If it's not possible to address the excessive newlines, I'd rather remove the max_line_length for now
0marperez
approved these changes
Feb 20, 2025
Contributor
Author
|
The ktlint problems keep piling up so we're abandoning this PR for now. A new PR that just cleans up the compiler warning is up as #82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
Two major changes:
Kotlin Gradle Plugin errors
After upgrading to Kotlin 2.1.0, we started seeing Kotlin Gradle Plugin errors in our builds:
This is being caused by our ktlint rules and plugin automatically bundling the compiler into its dependencies. This change removes kotlin-compiler-embeddable from several places where it was leaking into the buildscript classpath.
Unify ktlint versions
Previously, we hardcoded an outdated version of ktlint into our
Project.configureLintingmethod. This change uses a build-time version file to keep the version in sync with libs.versions.toml.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.